Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include comparison with git/contrib/diff-highlight #192

Closed
waldyrious opened this issue May 16, 2020 · 3 comments
Closed

Include comparison with git/contrib/diff-highlight #192

waldyrious opened this issue May 16, 2020 · 3 comments

Comments

@waldyrious
Copy link
Contributor

The comparison table in the README is great (I wish more projects did that!), but it looks like the diff-highlight script that is included in the git project is missing from it. It would be great if it were included as well.

@waldyrious
Copy link
Contributor Author

waldyrious commented May 16, 2020

Here are some screenshots that show some differences:

git:
git

diff-highlight
diff-highlight

delta:
delta

@dandavison
Copy link
Owner

dandavison commented May 16, 2020

Thanks again. I wasn't aware of diff-highlight when I made that README content. Is it right to say that diff-so-fancy is built on top of diff-highlight?

https://github.com/so-fancy/diff-so-fancy/blob/master/lib/DiffHighlight.pm
https://github.com/git/git/blob/master/contrib/diff-highlight/DiffHighlight.pm

@waldyrious
Copy link
Contributor Author

I wasn't aware of that! It makes sense — those files are identical for the most part. I'd say diff-highlight should be mentioned in the title of diff-so-fancy column, just to help people who may not be aware of the close relationship between the two :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants