Potential problem with github.utils.fileContents

[mxstbr]

I tried adding my very own danger-plugin-flow to our Peril setup (https://github.com/withspectrum/peril-settings), but as soon as I did that and added an unflowtyped file (to make the plugin fail to see whether it works or not) I got a "Bad credentials" error:

Any clues what could be happening here? I specifically used github.utils.fileContents instead of fs for Peril compat, but I might totally be missing something.

[mxstbr]

It's weird because Peril managed to comment in the PR, so it obviously got the GitHub token... somewhere, but then somewhere else it doesn't anymore or something?

[orta]

github.utils.fileContents doesn't use the same Peril API under the hood as the main comment posting, but is a transformed version of the OctoKit module - https://github.com/danger/danger-js/blob/c4a1d99fb7bdc387cd7876326ec93e09baf3a942/source/platforms/github/GitHubUtils.ts#L32-L51

It's possible that the GitHub API given to the create that fileContents isn't author correctly

[mxstbr]

That'd mean something's going wrong here, right?

https://github.com/danger/danger-js/blob/3eb635cb61885187e39ec9c2cf35c32de2317779/source/runner/jsonToDSL.ts#L46-L62

[mxstbr]

Too many layers of indirection for an outside to follow 😅 Not sure where the problem could lie beyond that method, any ideas?

[orta]

Yeah, no, I woundn't recommend digging into this one! The heart of the danger runner is super complex I'm afraid

But it's something around this.

[orta]

I have a long flight tomorrow where I intend to work on #240 - so I'll keep my eyes open for this too

[mxstbr]

Sounds great to me, thank you!

[orta]

This should be fixed in #247

[mxstbr]

Let me know when a new release is out—I'll have to deploy a fresh version of Peril for it to update, right?

[orta]

Yep, see https://github.com/danger/peril/blob/master/docs/updating_peril.md

[mxstbr]

On it—will update, then reenable and see if it's fixed!

[mxstbr]

IT WORKED!!! 🎉

Thanks for the quick resolution here, much appreciated.

[orta]

Thanks for the solid bug report, I should move some of my plugins to use that API too

[mxstbr]

Ah crap, I spoke too soon, now it's no longer editing its own comments:

[mxstbr]

I definitely have all the env vars set correctly since this worked before as long as I wasn't using the GitHub API, so it's gotta be something in that same area of the code probably? Any quick gut ideas?

[orta]

Hrm, could it be #219 ?

[orta]

However, the env var to double check is PERIL_BOT_USER_ID

[mxstbr]

Definitely sounds like #219

[orta]

OK, I'll have a proper think about this over the weekend.

It should be possible to add support coalescing multiple runs to all happen sycnronously without a db, devoted some time to the idea on the airplane

[mxstbr]

Closing as a duplicate of #219 and tracking that!