Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push new docker image to support SSO #1134

Closed
yggdrasil-tynor opened this issue Sep 11, 2020 · 11 comments
Closed

Push new docker image to support SSO #1134

yggdrasil-tynor opened this issue Sep 11, 2020 · 11 comments
Labels
better for forum This issue is probably better posted at the Discourse forum

Comments

@yggdrasil-tynor
Copy link

Was released 2 days ago: https://github.com/bitwarden/web/releases/tag/v2.16.0

@yggdrasil-tynor yggdrasil-tynor added the better for forum This issue is probably better posted at the Discourse forum label Sep 11, 2020
@BlackDex
Copy link
Collaborator

SSO Will not work without server-side changes.
We probably have to implement a lot of code to support this.
Only updating the web-vault will not do the trick.

@PrivatePuffin
Copy link

SSO Will not work without server-side changes.
We probably have to implement a lot of code to support this.
Only updating the web-vault will not do the trick.

I've looked into it, the server-side changes are actually quite minimal. Their implementation is basically comparable to a reverse proxy in front of bitwarden (but integrated), it does not replace the normal login and master-password requirements.

Some more info:
https://github.com/bitwarden/server/commits/fd6b10df564778ea73c00e8dcecc00aa74c5eb7d/src/Core/Enums/SsoType.cs
https://bitwarden.com/help/article/getting-started-with-sso/

@xdubx
Copy link

xdubx commented Sep 14, 2020

It would play into my hands if that were to be implemented. But I can only support the statement of Ornias1993.

@BlackDex
Copy link
Collaborator

Everyone can create a PR to implement this 😉.
Would be nice to have this, including all lot of other stuff.
When someone has time to implement this it will probably be pushed and merged.

@littlebigmedia
Copy link

This would be huge if added correctly!

@BlackDex BlackDex mentioned this issue Oct 8, 2020
61 tasks
@BlackDex
Copy link
Collaborator

BlackDex commented Oct 8, 2020

To keep the issue tracker more focused, I'm closing this issue in favor of the meta issue at #246

@BlackDex BlackDex closed this as completed Oct 8, 2020
@PrivatePuffin
Copy link

@BlackDex Besides the fact that it has nothing to do with a docker image needing to be pushed.

@mqus mqus mentioned this issue Oct 19, 2020
@pinpox
Copy link

pinpox commented Jul 22, 2021

I'd like to implement this, but would need a bit of guidance since I've not worked on valtwarden yet. @Ornias1993 What/where would be a good starting point for the changes you mentioned? Would be great to get any pointers!

@jiwanovski87
Copy link

@pinpox Have you already started with the implementation?

@pinpox
Copy link

pinpox commented Nov 3, 2021

@jiwanovski87 There has been some work here: #1955

@BloodyIron
Copy link

Can we get SAML?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better for forum This issue is probably better posted at the Discourse forum
Projects
None yet
Development

No branches or pull requests

8 participants