Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️[NOTE] BREAKING CHANGE sinces v1.31.0 #4024

Open
BlackDex opened this issue Nov 3, 2023 · 0 comments
Open

⚠️[NOTE] BREAKING CHANGE sinces v1.31.0 #4024

BlackDex opened this issue Nov 3, 2023 · 0 comments
Labels
notes Used for notes or meta issues

Comments

@BlackDex
Copy link
Collaborator

BlackDex commented Nov 3, 2023

Hello,

We intend to remove the custom Websocket implementation currently included in Vaultwarden.
This implementation uses a separate port (3012) which you needed to configure correctly into your reverse proxy for Websocket notifications to work.

Thanks to the work of @SergioBenitez and @Mai-Lapyst to add Websocket support to Rocket we can now provide this without custom ports and complex reverse proxy configurations.

Also, the new Login with device feature only works via this new Rocket Websocket implementation, and not via the old implementation.
So, to make full use of Vaultwarden we strongly encourage you to adjust your reverse proxy configuration to work with the new setup, since the old way will be removed from the next stable version.

Please check the wiki's Proxy Examples for the updated versions.
Also, if you see any outdated example and know how to update it, please be so kind to help us and update the wiki example.

If you have any questions regarding this, please check the discussion regarding this change, and place your questions there.

For the PR which includes these changes see: #4001

Repository owner locked as too heated and limited conversation to collaborators Nov 3, 2023
@BlackDex BlackDex pinned this issue Nov 3, 2023
@BlackDex BlackDex changed the title ⚠️[NOTE] BREAKING CHANGE in upcoming stable version ⚠️[NOTE] BREAKING CHANGE in upcoming v1.30.0 stable version Nov 3, 2023
@BlackDex BlackDex changed the title ⚠️[NOTE] BREAKING CHANGE in upcoming v1.30.0 stable version ⚠️[NOTE] BREAKING CHANGE in upcoming v1.31.0 stable version Nov 5, 2023
@BlackDex BlackDex changed the title ⚠️[NOTE] BREAKING CHANGE in upcoming v1.31.0 stable version ⚠️[NOTE] BREAKING CHANGE sinces v1.31.0 Oct 13, 2024
@BlackDex BlackDex added the notes Used for notes or meta issues label Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notes Used for notes or meta issues
Projects
None yet
Development

No branches or pull requests

1 participant