Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The page run out of memory when file is undefined #1040

Closed
roddolf opened this issue Oct 2, 2015 · 3 comments
Closed

The page run out of memory when file is undefined #1040

roddolf opened this issue Oct 2, 2015 · 3 comments
Labels
enhancement

Comments

@roddolf
Copy link

roddolf commented Oct 2, 2015

I have upgraded from 7.0.17 to 8.0.6 and when I upload my form, which can contain or not a file (undefined), the page crashes because it tries consume all the memory and cpu.

The was no poblem with this in the previous version.
@roddolf
Copy link
Author

roddolf commented Oct 2, 2015

Sorry, I have seen that the error is not by the undefined file.

Looking at the code, it appears that now the extra data is added recursively, and my data had a $promise inside, so it caused an infinite cycle.

@roddolf roddolf closed this as completed Oct 2, 2015
@danialfarid
Copy link
Owner

Circular reference detection.

@danialfarid danialfarid reopened this Oct 2, 2015
danialfarid pushed a commit that referenced this issue Oct 2, 2015
Fixed #1036, #1040, added ng-model-options and image drop from page
1d3dee5
danialfarid pushed a commit that referenced this issue Oct 2, 2015
Fixed #1036, #1040, added ng-model-options and image drop from page
99597e5
@danialfarid
Copy link
Owner

Since version 9.0.3 you will get an error if you have circular reference in your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danialfarid @roddolf