-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Realm integration to another repository #1756
Comments
We have. A lot. Unfortunately this complicates things... So this makes: Currently, both Pods and Carthage do not support any kind of cyclic dependencies. They did not implement even the simplest algorithm to find redundancies like this and resolve them, as in practice it can get complicated. So for ease of use we are keeping things as it is right now. I'll leave this open for now. |
I understand, thanks for the quick answer! In the meantime, I think I'll create a quick fork and remove Realm dependencies in there. I hope this will resolve my 20-min-long |
Make sure to update your fork frequently, as important bugfixes and new features come in.... |
If you find Carthage takes too long use cocoapods. You can specify to only build charts and not chartsrealm since they have subspecs. I tried out Carthage a while back but went back to cocoapods because it's faster and simpler. |
That's subjective. For me, CocoaPods is easier, but Carthage is simpler. 😉 |
Ya I meant easier ;) |
@danielgindi can you update realm to 2.x ? |
Pull requests are always welcome 😉 |
@danielgindi Seems like the current Moving |
@getaaron, not all of it, ChartsDemo still holds more demos without realm. I agree we could separate them, but so far, I just needed one time building and downloading for Realm, by carthage. It should not build all the time? |
@danielgindi I'm in favor to move ChartsRealm to another repo.
This make me crazy because I only use Charts... |
Well Carthage really doesn't want to add subspecs so if you don't want to download everything all the time use cocoapods or complain to the Carthage maintainers. Separate repos make our lives much harder for little gain. We could split the demos into 2 targets but that really doesn't fix some of the problems mentioned here. |
+1 to removing the Realm dependency. It isn't a core part of the Charts library or even related; it is a nice to have. You already did the work to split the dependencies, so separate repo seems to make sense. AlamoFire does the same thing. For me, it isn't about build times or anything, just project maturity. Seeing Realm pop up unexpectedly in |
I agree with @donnellyk. |
@donnellyk Until we think of a solution that answers the major concerns - we can't do that. And believe me, we want to! |
@danielgindi Fair enough. Which concerns are that? Maybe we can help? 🙂 |
At first we thought about keeping the Realm stuff in the project - for ease of maintainability. Now we're left with the desire to keep the Demo with the showcase of Realm related stuff, both for the users to be accessible, and for us when testing while developing.
The original main concern was more about the users: There's very high demand to ChartsRealm. Current situation makes ChartsRealm very visible and accessible. About developing flow - Maybe we should just bite the bullet, get used to it. There's not much develpoment going on on the ChartsRealm side anyway (except for implementing the new ObjC support stuff on Realm which was released a few days ago following my PR). I was generally very busy lately with many things - so I want to sit down and close some issues, merge PRs etc., and then maybe try to separate the ChartsRealm repo and see how it goes. |
@danielgindi finally catch you here. Yes we have many things to fix before thinking about Realm.. 😂 |
Yeah it's been some busy days :-) Still are... |
Okay so I'm done splitting the repo and moving the realm stuff to https://github.com/danielgindi/ChartsRealm. |
Have you considered moving
ChartsRealm
to another repository, that depends on bothCharts
andRealm
?Right now, they are both in this repository and in the same project. That causes some dependency managers, like Carthage, to build all
Charts
,ChartsRealm
andRealm
itself, even if its integration is not used.The text was updated successfully, but these errors were encountered: