Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xAxis.valueFormatter = self create retain cycle #2039

Closed
hotuanlinh89 opened this issue Jan 6, 2017 · 1 comment
Closed

xAxis.valueFormatter = self create retain cycle #2039

hotuanlinh89 opened this issue Jan 6, 2017 · 1 comment

Comments

@hotuanlinh89
Copy link

When you create CombinedChart. Config ChartXAxis.
ChartXAxis *xAxis = _chartView.xAxis;
xAxis.labelPosition = XAxisLabelPositionBottom;
xAxis.axisMinimum = 0.0;
xAxis.granularity = 1.0;
xAxis.valueFormatter = self;

It's create memory leak. Please help.
@hotuanlinh89 hotuanlinh89 changed the title xAxis.valueFormatter = self retain count xAxis.valueFormatter = self create retain cycle Jan 6, 2017
@liuxuan30
Copy link
Member

refer this: #1854
You can either change to weak or not use self

liuxuan30 added a commit to liuxuan30/Charts that referenced this issue Jan 10, 2017
@liuxuan30
Use weak for axisValueFormatter, addresses ChartsOrg#1873, ChartsOrg#…
fc0e121 
…1854, ChartsOrg#2039
@liuxuan30 liuxuan30 mentioned this issue Jan 10, 2017
Closed
@ehsan-black ehsan-black mentioned this issue Jul 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liuxuan30 @hotuanlinh89