Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing imports for iOS 7 support #1205

Merged
merged 2 commits into from
Jul 4, 2016
Merged

Add missing imports for iOS 7 support #1205

merged 2 commits into from
Jul 4, 2016

Conversation

VincentSit
Copy link
Contributor

Same like #45. This can cause compile failure in iOS 7 like #44. I just ran into this problem.

@liuxuan30
Copy link
Member

why not import CoreGraphics?

@VincentSit
Copy link
Contributor Author

VincentSit commented Jul 1, 2016 •
edited
Loading

Updated.

The reason is for consistency with the code style in #45.

I didn't read the source code before, didn't notice the style has been changed.

The 7eb5810 is useless for now, you can close this PR if you want to keep the commit history clean. I don't think it's necessary to open a new PR.

@liuxuan30 liuxuan30 merged commit 69998e0 into ChartsOrg:master Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentSit @liuxuan30