Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial link added to readme #2484

Merged
merged 2 commits into from Sep 2, 2017
Merged

tutorial link added to readme #2484

merged 2 commits into from Sep 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2017

Just added link to beginner-friendly tutorial / example using a couple of the charts with Swift and setting up (not using Realm)

@codecov-io
Copy link

codecov-io commented May 29, 2017

Codecov Report

Merging #2484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2484   +/-   ##
=======================================
  Coverage   19.65%   19.65%           
=======================================
  Files         112      112           
  Lines       13714    13714           
=======================================
  Hits         2696     2696           
  Misses      11018    11018

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b007b02...1286da0. Read the comment docs.

@liuxuan30
Copy link
Member

Thanks, but needs @danielgindi review, can be a long time

@pmairoldi
Copy link
Collaborator

Looks good. Great detail. Will resolve conflicts and merge.

@pmairoldi pmairoldi merged commit 79b6049 into ChartsOrg:master Sep 2, 2017
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants