-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift iOS Demos #2628
Swift iOS Demos #2628
Conversation
Uploading from GitHub
Codecov Report
@@ Coverage Diff @@
## master #2628 +/- ##
=======================================
Coverage 19.64% 19.64%
=======================================
Files 113 113
Lines 13792 13792
=======================================
Hits 2709 2709
Misses 11083 11083 Continue to review full report at Codecov.
|
This pull request is purely additive and does not change anything in the framework. It's very easily testable and is a great resource for the many iOS developers who never learned Objective-C. |
Thanks! It might some time to review and get merged. Quite short handed :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right approach. If we want both objective-c and swift demos they should belong to the same project not two separate ones. One demo project makes it easier to find. What you could do is just add the swift files to the existing project and create a new swift target in that project. That way you can reuse all the nibs and resources from the objective-c code.
Don't know why I didn't do that in the first place, but it's now one project with 2 targets |
@petester42 @liuxuan30 Your requested changes have been made. |
I’ll review this later tonight or tomorrow. Fairly straightforward. Should be good to go. |
gees, can someone stop @jjatie sending PRs lol. I saw dozens of PRs when I just wake up. |
Added Swift version of all the iOS demos.