Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift iOS Demos #2628

Merged
merged 8 commits into from
Nov 15, 2017
Merged

Swift iOS Demos #2628

merged 8 commits into from
Nov 15, 2017

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Jul 21, 2017

Added Swift version of all the iOS demos.

jacobchristie and others added 2 commits July 21, 2017 17:25
@codecov-io
Copy link

codecov-io commented Jul 21, 2017

Codecov Report

Merging #2628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2628   +/-   ##
=======================================
  Coverage   19.64%   19.64%           
=======================================
  Files         113      113           
  Lines       13792    13792           
=======================================
  Hits         2709     2709           
  Misses      11083    11083

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1811c7...b4f84b6. Read the comment docs.

@jjatie
Copy link
Collaborator Author

jjatie commented Jul 28, 2017

This pull request is purely additive and does not change anything in the framework. It's very easily testable and is a great resource for the many iOS developers who never learned Objective-C.

@liuxuan30
Copy link
Member

Thanks! It might some time to review and get merged. Quite short handed :(

@pmairoldi pmairoldi self-requested a review September 7, 2017 04:15
Copy link
Collaborator

@pmairoldi pmairoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach. If we want both objective-c and swift demos they should belong to the same project not two separate ones. One demo project makes it easier to find. What you could do is just add the swift files to the existing project and create a new swift target in that project. That way you can reuse all the nibs and resources from the objective-c code.

@jjatie
Copy link
Collaborator Author

jjatie commented Sep 17, 2017

Don't know why I didn't do that in the first place, but it's now one project with 2 targets

@jjatie
Copy link
Collaborator Author

jjatie commented Nov 6, 2017

@petester42 @liuxuan30 Your requested changes have been made.

@pmairoldi
Copy link
Collaborator

I’ll review this later tonight or tomorrow. Fairly straightforward. Should be good to go.

@liuxuan30
Copy link
Member

gees, can someone stop @jjatie sending PRs lol. I saw dozens of PRs when I just wake up.

@pmairoldi pmairoldi merged commit 3672219 into ChartsOrg:master Nov 15, 2017
@jjatie jjatie deleted the demos branch November 15, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants