Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Release signing configuration to "iOS Developer" to improve Carthage compatibility #297

Merged
merged 1 commit into from
Aug 15, 2015

Conversation

JaviSoto
Copy link
Contributor

Carthage was failing to build this. I believe that with iPhone Distribution you need a special profile to sign this library. It works with simply iPhone Developer. This shouldn't be an issue for anyone because the frameworks end up being signed with your application's profile when submitting to Apple.

@danielgindi
Copy link
Collaborator

Why would carthage fail to build this? Doesn't it use your project's certificate?

@JaviSoto
Copy link
Contributor Author

I don't think so.
It fails because I don't have a distribution certificate with an associated profile for that bundle ID, but I do have a wildcard development one.

This is the error that building with Carthage outputs:

Code Sign error: No code signing identities found: No valid signing identities (i.e. certificate and private key pair) were found.
CodeSign error: code signing is required for product type 'Framework' in SDK 'iOS 8.0'
A shell task failed with exit code 65:
** BUILD FAILED **

@danielgindi
Copy link
Collaborator

So you do not have a distribution certificate for your project at all? Maybe that is what you should fix?..

@danielgindi
Copy link
Collaborator

The thing is if I accept this PR then this might make trouble for those with in-house distribution

@JaviSoto
Copy link
Contributor Author

I think it's much more likely that people will develop apps, at least at the beginning, with only a development certificate. This is how all the other projects I've seen are set up, and it's the Xcode default I think.

@danielgindi
Copy link
Collaborator

I agree

danielgindi added a commit that referenced this pull request Aug 15, 2015
Changed Release signing configuration to "iOS Developer" to improve Carthage compatibility
@danielgindi danielgindi merged commit 2eeeb63 into ChartsOrg:swift-2.0 Aug 15, 2015
@JaviSoto
Copy link
Contributor Author

Thanks :)

@JaviSoto JaviSoto deleted the swift-2.0 branch August 15, 2015 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants