Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

feat!: rename defineConfigWithNuxt to defineVitestConfig #45

Merged
merged 2 commits into from
Jan 25, 2023
Merged

feat!: rename defineConfigWithNuxt to defineVitestConfig #45

merged 2 commits into from
Jan 25, 2023

Conversation

antfu
Copy link
Collaborator

@antfu antfu commented Jan 25, 2023

No description provided.

@antfu
Copy link
Collaborator Author

antfu commented Jan 25, 2023 •
edited
Loading

/cc @danielroe I am struggling between extendVitestConfigForNuxt and extendVitestConfigWithNuxt, any preference?

@danielroe
Copy link
Owner

danielroe commented Jan 25, 2023 •
edited
Loading

what about just defineVitestConfig, but exported from nuxt-vitest it implies that it is compatible with Nuxt?

@antfu
Copy link
Collaborator Author

antfu commented Jan 25, 2023

Indeed, good idea!

@antfu antfu changed the title feat!: rename defineConfigWithNuxt to extendVitestConfigForNuxt feat!: rename defineConfigWithNuxt to defineVitestConfig Jan 25, 2023
@antfu antfu merged commit eb8dc41 into main Jan 25, 2023
@antfu antfu deleted the feat/rename branch January 25, 2023 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
nuxt-vitest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @danielroe