Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is noise optimized in the first step? #34

Open
caopulan opened this issue Apr 25, 2022 · 1 comment
Open

Is noise optimized in the first step? #34

caopulan opened this issue Apr 25, 2022 · 1 comment

Comments

@caopulan
Copy link

G = copy.deepcopy(G).eval().requires_grad_(False).to(device).float() # type: ignore

Although 'noise constant' is updated at the end of optizimation, G is a deepcopy version and deleted. So does optimized noise work in inference?

@rardz
Copy link

rardz commented May 7, 2022

From the code, it seems the optimized 'noise constant' in the first step will be abandoned, and in the next pti step, the model just use another irrelevant constant noise.
However it was a little strange why the authors choose to keep the pti step noise constant. Especially in the multi image pti case, how will different images should share a same set of constant noise? I also think there must be something wrong here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants