Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Request Loader not detecting installed apps with icon #82

Closed
randomvector opened this issue Aug 8, 2017 · 10 comments
Closed

Icon Request Loader not detecting installed apps with icon #82

randomvector opened this issue Aug 8, 2017 · 10 comments

Comments

@randomvector
Copy link

When updating the Candybar Library core from 3.2.2 to 3.3.0 the icon request loader on the home screen does not detect the apps that have associated icons. Works as it should on version 3.2.2. I have cleaned the project before building and changed no other code between updates.

@danimahardhika
Copy link
Owner

danimahardhika commented Aug 8, 2017

Someone also reported it in G+ community here. Since there's not enough information, I still not able to confirm if this is a bug.

Try to use the SNAPSHOT. Open build.gradle and change compile 'com.github.danimahardhika.candybar-library:core:3.3.0' to compile 'com.github.danimahardhika.candybar-library:core:-SNAPSHOT'.

And tell me the error message appear.

INFO: It's working just fine on my side

@randomvector
Copy link
Author

randomvector commented Aug 8, 2017

Hi I compiled the SNAPSHOT as requested. When launching activity it pops up with "Error: Unable to read appfilter.xml" toast

(My appfilter.xml is in XML folder and no red underline errors)

@danimahardhika
Copy link
Owner

@randomvector Could you please send your appfilter.xml to me?

@randomvector
Copy link
Author

Can I send it privately?

@danimahardhika
Copy link
Owner

Yes you can send it via hangouts or directly to my email danimahardhika112[at]gmail[dot]com

@randomvector
Copy link
Author

Thanks. I've emailed it to you

@danimahardhika
Copy link
Owner

danimahardhika commented Aug 8, 2017

Turns out this is happened because there's a mistake in your appfilter.xml. Check line 65,
<item component="ComponentInfo{com.android.dialer/com.android.dialer.DialtactsActivity}" prefix="phone" />, it should be
<item component="ComponentInfo{com.android.dialer/com.android.dialer.DialtactsActivity}" drawable="phone" />

Check line 423, 442, and 810 too.

I'll make the dashboard ignore those mistake in next release

@randomvector
Copy link
Author

I changed the code but the icon loader still doesn't load apps with icons on 3.3.0

@danimahardhika
Copy link
Owner

@randomvector Check line 65, 423, 442, and 810 too.

@randomvector
Copy link
Author

randomvector commented Aug 8, 2017

Hi,

Thanks that fixed it! drawgooble=lol

Really appreciate your help 👍

@danimahardhika danimahardhika self-assigned this Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants