-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Acceptance of Terms and Privacy Policy on First Login #3650
Comments
I actually implemented this myself, but I don't feel ready to send a pull request because it's only using LocalStorage rather than the database as I didn't have time to add the routes to store it in Mongo. It works well though, if you don't accept it logs you out, otherwise you get to use it (until you change browser or device). |
Maybe we can make this a more general feature to have popups on login/first time use/etc.? |
Aweseome @maxesse @danny-avila a more general approach would be nice. Maybe it helps to have a first impression from @maxesse solution? |
Next week I'm gonna tidy it up, put the text in some .env variables, and see if I can add the route to store the acceptance in the db, and I'll do a pull request if you want. If @danny-avila prefers to take it over I can also just paste here the component. |
Awesome! Thank you all. @maxesse @danny-avila Maybe i am wrong but the buttons in the modal are only colored while hover. Maybe samething like this? diff --git a/client/src/components/ui/TermsAndConditionsModal.tsx b/client/src/components/ui/TermsAndConditionsModal.tsx
index c9bc7912..a15c41e2 100644
--- a/client/src/components/ui/TermsAndConditionsModal.tsx
+++ b/client/src/components/ui/TermsAndConditionsModal.tsx
@@ -72,13 +72,13 @@ const TermsAndConditionsModal = ({
<>
<button
onClick={handleDecline}
- className="border-border-none bg-surface-500 dark:hover:bg-surface-600 inline-flex h-10 items-center justify-center rounded-lg px-4 py-2 text-sm text-white hover:bg-gray-600"
+ className="border-border-none inline-flex h-10 items-center justify-center rounded-lg px-4 py-2 text-sm text-white hover:bg-gray-700 bg-gray-500 dark:border-gray-600"
>
{localize('com_ui_decline')}
</button>
<button
onClick={handleAccept}
- className="border-border-none bg-surface-500 inline-flex h-10 items-center justify-center rounded-lg px-4 py-2 text-sm text-white hover:bg-green-600 dark:hover:bg-green-600"
+ className="border-border-none inline-flex h-10 items-center justify-center rounded-lg px-4 py-2 text-sm text-white hover:bg-green-700 dark:hover:bg-green-700 bg-green-500
"
>
{localize('com_ui_accept')}
</button> |
You're right - I should have tested it in light mode, as I always use it in dark mode and I didn't spot the issue. @danny-avila are you happy to apply @derhelge fix or do you want a PR? It works fine with his change. |
What features would you like to see added?
It would be beneficial to introduce an intermediate step upon the first login where users must accept the Terms of Service and Privacy Policy before they can use the service. This acceptance should be stored in the database. Also, the feature should be configurable via variables in the configuration file to allow optional activation.
More details
Which components are impacted by your request?
General, UI
Pictures
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: