Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generic multi call scheme #4

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

Support generic multi call scheme #4

wants to merge 9 commits into from

Conversation

roienatan
Copy link
Contributor

@roienatan roienatan commented Nov 4, 2020 •
edited
Loading

resolves: #5

Also:

  • Update the single call generic scheme to be consistent with the multi-call (removed SelectSearch component)
  • Use same validation code to reduce duplicated code
  • Fix issue that user data is not saved when you close the proposal modal and go back.
  • More minor code improvements

@roienatan roienatan added the enhancement New feature or request label Nov 4, 2020
@roienatan roienatan requested a review from orenyodfat November 4, 2020 09:25
@orenyodfat orenyodfat temporarily deployed to alchemy-2-generic-multi-wwjast November 4, 2020 09:25 Inactive
@orenyodfat orenyodfat temporarily deployed to alchemy-2-generic-multi-wwjast November 4, 2020 09:33 Inactive
@orenyodfat orenyodfat mentioned this pull request Nov 4, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyodfat orenyodfat Awaiting requested review from orenyodfat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support generic multi call scheme
2 participants
@roienatan @orenyodfat