New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few miscellaneous items on ExternalLocking4Reputation and Auction4Reputation #542

Open

dkent600 opened this issue Sep 27, 2018 · 1 comment

Contributor

dkent600 commented Sep 27, 2018

This in ExternalLocking4Reputation.initialize is redundant with what already exists in Locking4Reputation._initialize:

require(_lockingEndTime > _lockingStartTime,"_lockingEndTime should be greater than _lockingStartTime");

consider indexing the following event arguments:

FixedReputationAllocation.BeneficiaryAddressAdded._beneficiary
Auction4Reputation.Bid._bidder

FixedReputationAllocation.enabled will crash when numberOfBeneficiaries is zero:

beneficiaryReward = uint256(int216(reputationReward).div(int256(numberOfBeneficiaries)).fromReal());

Should we do a require with a message?

The text was updated successfully, but these errors were encountered:

Contributor Author

dkent600 commented Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment