Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resolving fast #64

Closed
jakemac53 opened this issue Mar 1, 2016 · 2 comments
Closed

Make resolving fast #64

jakemac53 opened this issue Mar 1, 2016 · 2 comments
Assignees
Milestone

Comments

@jakemac53
Copy link
Contributor

Now that the resolver is fixed, it appears to be dreadfully slow :(.

@jakemac53 jakemac53 added the bug label Mar 1, 2016
@jakemac53 jakemac53 self-assigned this Mar 1, 2016
@jakemac53
Copy link
Contributor Author

Looks like the current resolver from code_transformers (which we are using) isn't sharing sources between resolvers. This is probably because it had no info about phases since it was built on top of pub, but since we are building in support we should be able to be better. Unfortunately that means re-implementing all the functionality for this package :(.

@jakemac53
Copy link
Contributor Author

One consideration here is tracking which files are used. Since in the optimized version it won't actually be reading all inputs each time (presumably) we will need to manually add all transitive imports as deps whenever you resolve a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants