Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibTest/io/Process/start_A05_t01 needs to allow StateError #521

Closed
sortie opened this issue Feb 4, 2020 · 2 comments
Closed

LibTest/io/Process/start_A05_t01 needs to allow StateError #521

sortie opened this issue Feb 4, 2020 · 2 comments
Assignees

Comments

@sortie
Copy link

sortie commented Feb 4, 2020

The Dart SDK change "[dart:io] Backport semantic changes from the dart:io NNBD migration."
changed the behavior of detached processes, so accessing stdout, stderr, stdin, and exitCode will throw a StateError instead of returning null.

The LibTest/io/Process/start_A05_t01 test needs to be updated to reflect this new behavior.

Additionally the test is broken except on Linux and Windows as command and args are null. The test should be changed to provide a command on all operating systems. Using Platform.resolvedExecutable unconditionally seems like the easiest solution to have an executable on all operating systems. Actually this seems to be a recurring problem in several LibTest/io/Process tests and they should all be fixed as we also run then on Mac. If the operating system is not Windows, then it's reasonable to assume basic Unix commands are available.

@sortie
Copy link
Author

sortie commented Feb 6, 2020

The change was reverted due to unexpected breakage. The breakage was fixed. The CL is being relanded at https://dart-review.googlesource.com/c/sdk/+/134329. However, we'll now be sending this change through the breaking change policy, so co19 shouldn't be updated until the change is relanded.

@sgrekhov sgrekhov self-assigned this Feb 11, 2020
@sortie
Copy link
Author

sortie commented Feb 20, 2020

Breaking change request dart-lang/sdk#40483 was filed about this and the change landed in https://dart-review.googlesource.com/c/sdk/+/134329. co19 can now be updated though keep an eye on the breaking change issue for potential reverts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants