From e01eab3e1fa6d474f04ad8d919c7652010c5ee42 Mon Sep 17 00:00:00 2001
From: Kallen Tu <kallentu@google.com>
Date: Fri, 23 Feb 2024 09:18:40 -0800
Subject: [PATCH] Remove missingConstantConstructor warning. (#3674)

---
 lib/src/model/getter_setter_combo.dart |  6 +-----
 lib/src/model/package_graph.dart       |  1 -
 lib/src/warnings.dart                  | 15 ---------------
 3 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/lib/src/model/getter_setter_combo.dart b/lib/src/model/getter_setter_combo.dart
index 91af89bfd4..d5d3755598 100644
--- a/lib/src/model/getter_setter_combo.dart
+++ b/lib/src/model/getter_setter_combo.dart
@@ -17,7 +17,6 @@ import 'package:dartdoc/src/model/attribute.dart';
 import 'package:dartdoc/src/model/comment_referable.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/utils.dart';
-import 'package:dartdoc/src/warnings.dart';
 import 'package:meta/meta.dart';
 
 /// Mixin for top-level variables and fields (aka properties).
@@ -68,10 +67,7 @@ mixin GetterSetterCombo on ModelElement {
     var creationExpression = constantInitializer as InstanceCreationExpression;
     var constructorName = creationExpression.constructorName.toString();
     Element? staticElement = creationExpression.constructorName.staticElement;
-    if (staticElement == null) {
-      warn(PackageWarning.missingConstantConstructor, message: constructorName);
-      return original;
-    }
+    if (staticElement == null) return original;
     var target = getModelForElement(staticElement) as Constructor;
     var enclosingElement = target.enclosingElement;
     if (enclosingElement is! Class) return original;
diff --git a/lib/src/model/package_graph.dart b/lib/src/model/package_graph.dart
index 9ec6ba4e53..e6168f1f7b 100644
--- a/lib/src/model/package_graph.dart
+++ b/lib/src/model/package_graph.dart
@@ -455,7 +455,6 @@ class PackageGraph with CommentReferable, Nameable {
       PackageWarning.toolError ||
       PackageWarning.deprecated ||
       PackageWarning.unresolvedExport ||
-      PackageWarning.missingConstantConstructor ||
       PackageWarning.missingExampleFile ||
       PackageWarning.missingCodeBlockLanguage =>
         kind.messageFor([message])
diff --git a/lib/src/warnings.dart b/lib/src/warnings.dart
index 29d749eea9..1f072f3f37 100644
--- a/lib/src/warnings.dart
+++ b/lib/src/warnings.dart
@@ -285,21 +285,6 @@ enum PackageWarning implements Comparable<PackageWarning> {
     shortHelp: 'An export refers to a URI that cannot be resolved.',
     defaultWarningMode: PackageWarningMode.error,
   ),
-  missingConstantConstructor(
-    'missing-constant-constructor',
-    'constant constructor missing: {0}',
-    shortHelp:
-        'Dartdoc can not show the value of a constant because its constructor '
-        'could not be resolved.',
-    longHelp:
-        'To resolve a constant into its literal value, Dartdoc relies on the '
-        "analyzer to resolve the constructor. The analyzer didn't provide the "
-        "constructor for '$_namePlaceholder', which is usually due to an error "
-        'in the code. Use the analyzer to resolve the issue.',
-    // Defaults to ignore as this doesn't impact the docs severely but is
-    // useful for debugging package structure.
-    defaultWarningMode: PackageWarningMode.ignore,
-  ),
   missingExampleFile(
     'missing-example-file',
     'example file not found: {0}',