Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartium extraction from SDK causes SDK bot breakage #1491

Closed
jcollins-g opened this issue Aug 31, 2017 · 2 comments
Closed

dartium extraction from SDK causes SDK bot breakage #1491

jcollins-g opened this issue Aug 31, 2017 · 2 comments
Assignees
Labels
P0 A serious issue requiring immediate resolution

Comments

@jcollins-g
Copy link
Contributor

https://uberchromegw.corp.google.com/i/client.dart/builders/dart-sdk-linux-be/builds/15140/steps/generate%20sdks/logs/stdio

Reported by @terrylucas. Problem is here: https://github.com/dart-lang/dartdoc/blob/master/lib/src/model.dart#L2335.

a.element is allowed to be null but this code doesn't expect that.

@jcollins-g jcollins-g added the P0 A serious issue requiring immediate resolution label Aug 31, 2017
@jcollins-g jcollins-g self-assigned this Aug 31, 2017
@terrylucas
Copy link

Janice can you add the 1 line change datadoc gen to v0.13.0+2 (rev of last release v0.13.0+1 and this fix). Then I can change the DEPS to grab that release. The problem is the dart-sdk bot failure include zipping the sdk and building the dartdoc any failure with these 2 steps will cause the dart2js bots to not run.

@whesse will look at changing the recipe to separate the sdk zip and upload the sdk from the dartdoc gen. However, it would still be nice to get this fix in ASAP to keep the bots green.

@jcollins-g
Copy link
Contributor Author

The one line fix is not enough to make dartdoc pass in flutter using checked mode. Fortunately for us though, they aren't using checked mode. That still needs to be dealt with but is a matter for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution
Projects
None yet
Development

No branches or pull requests

2 participants