Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to ignore analyzer errors - or at least CompileTimeErrorCode.URI_HAS_NOT_BEEN_GENERATED #1595

Closed
kevmoo opened this issue Jan 19, 2018 · 3 comments
Labels
customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@kevmoo
Copy link
Member

kevmoo commented Jan 19, 2018

throw new DartDocFailure(

In the case of angulardart/angular_components#207, the error is CompileTimeErrorCode.URI_HAS_NOT_BEEN_GENERATED

We could just ignore these errors – or treat them as warnings to see if anything else fails

Or we could just add a flag to ignore errors.

@devoncarew
Copy link
Member

I think we should rely on the analysis_options.yaml file here, and just make sure dartdoc respects it. Should be fixed as part of #1586.

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-google3 Issues originating from or important to Angular labels Jan 19, 2018
@jcollins-g
Copy link
Contributor

jcollins-g commented Jan 19, 2018

With luck, I'll be working on #1586 first thing after dartconf, but if that takes too long we might consider the intermediate step Kevin suggested in a patch release (if this blocks angular?)

@jcollins-g
Copy link
Contributor

Migrating to the new analysis driver is not enough in and of itself to fix analysis_option handling. More details written up in #1586. However, the workaround is simple enough and I'll work on making that happen instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-google3 Issues originating from or important to Angular P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants