Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection_methods_unrelated_type to core #93

Closed
srawlins opened this issue Dec 8, 2022 · 3 comments · Fixed by #136
Closed

Add collection_methods_unrelated_type to core #93

srawlins opened this issue Dec 8, 2022 · 3 comments · Fixed by #136

Comments

@srawlins
Copy link
Member

srawlins commented Dec 8, 2022

This new rule guards against a super-set of code which iterable_contains_unrelated_type and list_remove_unrelated_type guard against. These two rules are in core.yaml, and could be replaced by collection_methods_unrelated_type.

https://dart-lang.github.io/linter/lints/collection_methods_unrelated_type.html

@devoncarew
Copy link
Member

@natebosch, @pq - thoughts on adding this rule?

cc also @mit-mit

@lrhn
Copy link
Member

lrhn commented Jun 7, 2023

All for adding this, with the same reasoning as the existing related lints (which then become unnecessary, #118).

@devoncarew
Copy link
Member

Approved for core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants