From f2277b9019eb8c180abc1e33c3b2e654c9806661 Mon Sep 17 00:00:00 2001 From: Jonas Finnemann Jensen Date: Thu, 15 Aug 2024 12:19:49 +0200 Subject: [PATCH 1/3] Update overrides.dart (#7936) Allowlist us to create `credilio_sbm` on behalf of the owner of `crediliosbm` --- app/lib/package/overrides.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/app/lib/package/overrides.dart b/app/lib/package/overrides.dart index 3f73dd5641..1d95596637 100644 --- a/app/lib/package/overrides.dart +++ b/app/lib/package/overrides.dart @@ -42,6 +42,7 @@ final _reservedPackageNames = [ 'hook', 'kotlin', // for yousefi@ 'ok_http', // https://github.com/dart-lang/http/tree/master/pkgs/ok_http + 'credilio_sbm', // for owner of package:crediliosbm ].map(reducePackageName).toList(); const redirectPackageUrls = { From b08cc54e68f9c1ac3495cccc942f9a9a85244bf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Thu, 15 Aug 2024 12:25:52 +0200 Subject: [PATCH 2/3] Keep dark theme class while in-page updates happen. (#7934) --- pkg/web_app/lib/src/page_updater.dart | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/web_app/lib/src/page_updater.dart b/pkg/web_app/lib/src/page_updater.dart index 2f043ba6e8..dc0874d013 100644 --- a/pkg/web_app/lib/src/page_updater.dart +++ b/pkg/web_app/lib/src/page_updater.dart @@ -44,8 +44,13 @@ Document _update( required bool pushState, required String? url, }) { + // The dark theme preference is encoded in the `` element's `class` + // attributes. We could re-run the initialization, but storing the current + // values and replacing the provided ones is simpler. + final oldClasses = document.body!.className; final doc = DomParser().parseFromString(html, 'text/html'); document.querySelector('body')!.replaceWith(doc.querySelector('body')!); + document.body!.className = oldClasses; _popStateFn!(); if (pushState) { final title = doc.querySelector('title')?.text; From a71abd39f2be121c1055843cb3fccf76d83a022f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Thu, 15 Aug 2024 12:45:37 +0200 Subject: [PATCH 3/3] Redirect package:flutter_gpu (#7942) --- app/lib/package/overrides.dart | 2 ++ app/lib/search/result_combiner.dart | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/lib/package/overrides.dart b/app/lib/package/overrides.dart index 1d95596637..32f6630fd7 100644 --- a/app/lib/package/overrides.dart +++ b/app/lib/package/overrides.dart @@ -51,6 +51,8 @@ const redirectPackageUrls = { 'https://api.flutter.dev/flutter/flutter_driver/flutter_driver-library.html', 'flutter_driver_extension': 'https://api.flutter.dev/flutter/flutter_driver_extension/flutter_driver_extension-library.html', + 'flutter_gpu': + 'https://main-api.flutter.dev/flutter/flutter_gpu/flutter_gpu-library.html', 'flutter_localizations': 'https://api.flutter.dev/flutter/flutter_localizations/flutter_localizations-library.html', 'flutter_test': diff --git a/app/lib/search/result_combiner.dart b/app/lib/search/result_combiner.dart index ca716e38c6..db5fcc443a 100644 --- a/app/lib/search/result_combiner.dart +++ b/app/lib/search/result_combiner.dart @@ -36,7 +36,7 @@ class SearchResultCombiner { ...?flutterSdkMemIndex?.search(query.query!, limit: 2), ]; if (sdkLibraryHits.isNotEmpty) { - // Do not display low SDK scores if the average package hits are more relevant on the page. + // Do not display low SDK scores if the top package hit is more relevant on the page. // // Note: we used to pick the lowest item's score for this threshold, but it was not ideal, // because promoted hit of the exact package name match may have very low score.