Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev branch: Unexpected modifications of pubspec.lock #3687

Closed
nex3 opened this issue Dec 8, 2022 · 2 comments
Closed

Dev branch: Unexpected modifications of pubspec.lock #3687

nex3 opened this issue Dec 8, 2022 · 2 comments

Comments

@nex3
Copy link
Member

nex3 commented Dec 8, 2022

Environment

  • Dart version (run dart --version): 2.19.0-440.0.dev
  • OS kind and version (e.g. "Windows 10, version 1809" or "macOS 12.4"): ubuntu-22.04
  • Are you using the Chinese community mirror or a corporate firewall? No

Problem

The latest Dart dev version seems to be modifying pubspec.lock unexpectedly at some point between beginning a dart run execution and executing a test. This breaks our tests, which check the time a required file was generated against pubspec.lock to ensure that the file is up-to-date. Is it possible that this is related to dart-lang/sdk#50422?

An example failing GitHub action: https://github.com/sass/dart-sass/actions/runs/3589202911/jobs/6041396294

Expected behavior

I would expect pubspec.lock not to be modified unless I actually run pub get and it changes the file.

Actual behavior

pubspec.lock is modified

@sigurdm
Copy link
Contributor

sigurdm commented Dec 8, 2022

I think this has the same root-cause as dart-lang/sdk#50617 (we redo the resolution unnecessarily in dart run).
It should be fixed by: #3678 that is rolled into dart-lang/sdk@258598e 2.19.0-454.0.dev and onwards, and a cherry-pick for the beta-series is here: dart-lang/sdk#50625.

Please reopen if I'm mistaken and/or the upcoming dev-releases still show this issue.

@sigurdm sigurdm closed this as completed Dec 8, 2022
@nex3
Copy link
Member Author

nex3 commented Dec 8, 2022

Yep, looks like our builds are green again 👍. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants