Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_JenkinsSmiHash should be exposed by SDK #25553

Closed
stereotype441 opened this issue Jan 21, 2016 · 1 comment
Closed

_JenkinsSmiHash should be exposed by SDK #25553

stereotype441 opened this issue Jan 21, 2016 · 1 comment
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Milestone

Comments

@stereotype441
Copy link
Member

The _JenkinsSmiHash class (sdk/lib/math/jenkins_smi_hash.dart) is useful enough that it has now been duplicated in 6 places:

pkg/analysis_server/lib/src/protocol/protocol_internal.dart (*)
pkg/analyzer/lib/src/generated/utilities_general.dart
runtime/observatory/lib/object_graph.dart
sdk/lib/html/dart2js/html_dart2js.dart
sdk/lib/html/dart2js/html_dartium.dart
tools/dom/templates/html/impl/imtl_ClientRect.darttemplate

(*Note that the implementation in analysis_server is could be replaced with a reference to the one in analyzer).

We should expose the SDK's implementation of _JenkinsSmiHash so that all the duplicate definitions can be eliminated.

This would also allow us to synthesize better code when generating default implementations of hashCode (an IntelliJ feature @jwren is currently working on).

@stereotype441 stereotype441 added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Jan 21, 2016
@stereotype441 stereotype441 added this to the 1.15 milestone Jan 21, 2016
@floitschG
Copy link
Contributor

Duplicate of #11617.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Projects
None yet
Development

No branches or pull requests

2 participants