Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript compilers support for --null-assertions in Dart 3.0 #50711

Closed
nshahan opened this issue Dec 13, 2022 · 5 comments
Closed

JavaScript compilers support for --null-assertions in Dart 3.0 #50711

nshahan opened this issue Dec 13, 2022 · 5 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dart2js web-dev-compiler
Milestone

Comments

@nshahan
Copy link
Contributor

nshahan commented Dec 13, 2022

Regarding the --null-assertions flag. It provides enhanced null safety errors when running without sound null safety. It was added as a tool to assist in large scale migrations so you can migrate a library and get some null safety errors at runtime when testing an app that isn't fully migrated. I believe this feature is considered totally obsolete in a world where all code being compiled should be null safe.

For DDC this is a question of what flags are supported when you try to run a debug app with package:webdev or flutter web. For dart2js it includes those and what flags are available through dart compile js.

cc @sigmundch @jakemac53 @fishythefish @mit-mit @itsjustkevin

@nshahan nshahan added web-dart2js P2 A bug or feature request we're likely to work on web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Dec 13, 2022
@nshahan nshahan changed the title JavaScript compilers support for --null-assertions in Dart 3.0 JavaScript compilers support for --null-assertions in Dart 3.0 Dec 13, 2022
@jakemac53
Copy link
Contributor

dart-lang/build#3424 drops support for this flag in build_runner so we won't pass it to the compilers any more (specifically kernel, ddc, and dart2js).

@nshahan
Copy link
Contributor Author

nshahan commented Mar 7, 2023

Just waiting on the unsound null safety flags to be removed from Flutter tool.

@mit-mit
Copy link
Member

mit-mit commented Mar 15, 2023

@nshahan is there a tracking issue for the Flutter tool flag issue?

@nshahan
Copy link
Contributor Author

nshahan commented Mar 16, 2023

@mit-mit yes the flag handling cleanup got rolled into flutter/flutter#118810.

@nshahan
Copy link
Contributor Author

nshahan commented Mar 21, 2023

Closing this issue because no more work is needed in the SDK but we ware still depending on the flag cleanup in Flutter Tools:

@nshahan nshahan closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P2 A bug or feature request we're likely to work on web-dart2js web-dev-compiler
Projects
None yet
Development

No branches or pull requests

5 participants