Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart2wasm] make dart.library.js_util false on conditional imports #56502

Open
sigmundch opened this issue Aug 16, 2024 · 1 comment
Open

[dart2wasm] make dart.library.js_util false on conditional imports #56502

sigmundch opened this issue Aug 16, 2024 · 1 comment
Labels
area-dart2wasm Issues for the dart2wasm compiler. type-enhancement A request for a change that isn't a bug

Comments

@sigmundch
Copy link
Member

Follow up from #55266

Eventually we may want to fully remove dart:js_util. It's already banned from most uses, but there are a few usages that need to be removed before it can be fully disallowed.

Meanwhile, I think we can be in the middleground where the direct import is allowed, but a conditional import is not.

@dart-github-bot
Copy link
Collaborator

Summary: The dart:js_util library is currently banned from most uses, but some remaining usages need to be removed before it can be fully disallowed. This issue proposes a middle ground where direct imports are allowed, but conditional imports are not.

@dart-github-bot dart-github-bot added area-dart2wasm Issues for the dart2wasm compiler. triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. type-enhancement A request for a change that isn't a bug labels Aug 16, 2024
@lrhn lrhn removed the triage-automation See https://github.com/dart-lang/ecosystem/tree/main/pkgs/sdk_triage_bot. label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart2wasm Issues for the dart2wasm compiler. type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants