Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop InvalidGenerationSourceError #454

Closed
natebosch opened this issue Mar 9, 2020 · 4 comments
Closed

Drop InvalidGenerationSourceError #454

natebosch opened this issue Mar 9, 2020 · 4 comments

Comments

@natebosch
Copy link
Member

This class does not follow best practices, and I think it's outlived it's usefulness. We'd also like to shift the concept of a build failure into the core build system instead of source_gen. The concept of writing "error" output to the generated file is also outdated. I don't think any of our build systems treat the file as having any useful content if it is a failure.

dart-lang/build#981

cc @davidmorgan - this class is used in built_value_generator. I think most of that error handling can be remove entirely. It should be fine to let the exception bubble up.

cc @jakemac53 @leonsenft

@davidmorgan
Copy link
Contributor

Thanks, filed an issue for built_value. Any timeline for this? I guess built_value will need updating before we can roll the updated source_gen to google3.

@natebosch
Copy link
Member Author

We'll hopefully have a migration plan or at least a design for a replacement before dropping it here so no rush for now.

@kevmoo
Copy link
Member

kevmoo commented Jul 10, 2020

FYI a3e3c9a does away w/ the idea of including error messages in source code

@natebosch
Copy link
Member Author

I think we turned out to expand usage of InvalidGenerationSource, and it does seem to be useful enough to keep.

@natebosch natebosch closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants