You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2285 highlighted that no tests are running on firefox in the integration_test/wasm directory, but it is not failing. When running on firefox alone we fail because no test cases run. There is a retry reported, then nothing. When running on both firefox and chrome, because the test cases do run on chrome, so we don't fail with the overall run having no test cases. Our check for no test cases is across suites, not per suite, but this might suggest we should change that.
The text was updated successfully, but these errors were encountered:
It looks like the Firefox version we use in CI is buggy. I'm able to reproduce this with Firefox 115.15.0, but not with the latest stable (131.0).
The behavior in version 115.15.0 is that it reports a Wasm validation error, which should be a bug in Firefox as the module is valid according to multiple other tools.
The reason why the test hangs is because it does not handle errors thrown in this line:
#2285 highlighted that no tests are running on firefox in the
integration_test/wasm
directory, but it is not failing. When running on firefox alone we fail because no test cases run. There is a retry reported, then nothing. When running on both firefox and chrome, because the test cases do run on chrome, so we don't fail with the overall run having no test cases. Our check for no test cases is across suites, not per suite, but this might suggest we should change that.The text was updated successfully, but these errors were encountered: