Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to package_config #483

Closed
mit-mit opened this issue Mar 7, 2022 · 3 comments
Closed

Migrate to package_config #483

mit-mit opened this issue Mar 7, 2022 · 3 comments
Assignees

Comments

@mit-mit
Copy link
Member

mit-mit commented Mar 7, 2022

The .packages file is being discontinued, so we should migrate to package_config.json (or rather its public API).

Some current uses:
https://cs.github.com/dart-lang/coverage?q=.packages

@liamappelbe
Copy link
Contributor

Looks like we already support package_config.json, and just use .packages as a fallback (see _parsePackages in resolver.dart). There's a few tests and tools to migrate though.

@liamappelbe
Copy link
Contributor

Users can pass .dart_tool/package_config.json or .packages to the --package flag in format_coverage. But it would probably make more sense to deprecate this flag and add a --package flag that takes the root directory of the package and uses findPackageConfig.

@liamappelbe
Copy link
Contributor

Closing this because the migration is done. Follow up work to change the flags tracked here: #484

@mosuem mosuem transferred this issue from dart-archive/coverage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants