Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

rxjava-promises and Android support #2

Closed
weefbellington opened this issue Nov 5, 2013 · 9 comments
Closed

rxjava-promises and Android support #2

weefbellington opened this issue Nov 5, 2013 · 9 comments
Milestone

Comments

@weefbellington
Copy link

Hello,

Is rxjava-promises supported on Android? I tried to install it as a Gradle dependency and I'm getting NoClassDefFoundErrors for all the classes from the jar -- no issues with other dependencies. Is it possibly compiled with Java 7, and if so would it be possible to compile an artifact using Java 6 instead for Android users?

Thanks,
David

@darylteo
Copy link
Owner

darylteo commented Nov 6, 2013

Can you provide more info on which class is not being found?

It is targetted at 1.7 yes, as it was never designed to work with Android (I'm not an Android developer).

Edit: ah, wait All the classes... can you provide me with potential steps to rectify this? Can you perhaps compile a local version in 1.6?

Regards,
Daryl

@weefbellington
Copy link
Author

Daryl,

Thanks for the quick response!

Yes, I expect that compiling with Java 6 would fix the issue. I'll try doing it from the Gradle script later and see if it works.

If that's all that's needed to fix the problem, would you consider deploying an Android-compatible artifact in the future? Asynchronous background operations are very, very common on Android, and having a Promises implementation on top of rxjava would be very handy.

@darylteo
Copy link
Owner

darylteo commented Nov 6, 2013

If there is lots of demand, I would love to... is RxJava android compatible?

Let me know how that goes, thanks.

@darylteo
Copy link
Owner

darylteo commented Nov 6, 2013

Aha apparently they do actively support Java 6+.

https://github.com/Netflix/RxJava/blob/master/rxjava-core/build.gradle#L4

Anyway, please give it a shot first. If it does work, then I will set the source compatibility to 6+ as well, and push a new version (or just overwrite the old one... naughty)

@darylteo
Copy link
Owner

darylteo commented Nov 7, 2013

Just realised I may have had some things in that that have broken the build... working on fixing it now with the updated compatibility. Stayed tuned.

@darylteo
Copy link
Owner

darylteo commented Nov 7, 2013

I just uploaded 1.1.2-SNAPSHOT. Can you give this a shot? If it works I will make a formal release.

You need to add sonatype's snapshot repository to your maven repositories.

https://oss.sonatype.org/content/repositories/snapshots/

Regards,
Daryl

@weefbellington
Copy link
Author

Daryl,

Thanks for the quick turnaround! I loaded the rxjava-promises-java:SNAPSHOT-1.1.2 artifact and I can confirm that it's working with my Android app. 🎉 🎈

Feel free to close this issue & thanks for supporting the Android community with your work.

Best,
David

@darylteo
Copy link
Owner

darylteo commented Nov 7, 2013

Okay I have to work now, I'll upload the full artifact to maven tonight.

Daryl

@darylteo
Copy link
Owner

darylteo commented Nov 8, 2013

Just pushed

https://oss.sonatype.org/content/repositories/releases/com/darylteo/rxjava-promises-java/

It should take a few hours to sync with Central. You can use it fully then.

Please continue to let me know if there are any issues =)

Regards,
Daryl

@darylteo darylteo closed this as completed Nov 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants