feat: deprecate RPC 'debug' to favor of 'logging' #6480
+8
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The rpc
debug
duplicates functionality of RPClogging
.Beside that it has next disadvantages:
debug
doesn't have any testsdebug
has our own implementation whilelogging
is supported by mainstreamlogging
can work in both modes "all except..." and "only ...", whiledebug
doesn't have a feature "all except..."Though, there's particular case when
debug
is more convenient: if you have several categories it's simplier to writedebug X+Y
rather thanlogging "[\"X\", \"Y\"]"
Discovered while doing https://github.com/dashpay/dash-issues/issues/63
What was done?
Deprecated rpc
debug
.There's some HowTo for
debug
users for smooth switch tologging
:For
debug all
:logging [\"all\"]
For
debug none
:logging '[]' '["all"]'
For
debug X+Y
:logging "[\"X\", \"Y\"]"
How Has This Been Tested?
Run unit and functional tests
Breaking Changes
It removes RPC
debug
Checklist: