Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using boolean array indexing in special case tests #94

Closed
tomwhite opened this issue Feb 6, 2022 · 0 comments
Closed

Avoid using boolean array indexing in special case tests #94

tomwhite opened this issue Feb 6, 2022 · 0 comments
Assignees

Comments

@tomwhite
Copy link
Contributor

tomwhite commented Feb 6, 2022

Boolean array indexing is optional in the spec since the output shape is data dependent. Libraries like Dask create output arrays where the shape is unknown, which causes the special case tests to fail since they use masking in their implementation. It would be good if these tests could avoid using boolean array indexing so the special cases can be checked in Dask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants