-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify correct rounding for sqrt #826
Comments
Is this something that's actually the case for existing libraries/devices? If so, there shouldn't be an issue with adding it. By the way, is your proposal for this to apply to both real and complex inputs or just to real inputs? |
Excellent point! My proposal is for this to apply just to real inputs. Given industry adoption of IEEE Std 754-2019, correct rounding is actually the case for existing libraries/devices. |
I believe the existing accuracy requirements for element-wise arithmetic operations are only intended to apply to real inputs.
does not result in correctly rounded real and imaginary components. |
Yes, I think this is correct. As the specification advocates for IEEE 754 compliance (with some caveats; e.g., subnormals) and IEEE 754 only applies to reals, we don't have an equivalent mandate for complex number operations. Accordingly, we should make this distinction explicit. Re: |
For those interested in the accuracy of complex operators/functions, my colleagues and I have done a comparison with different |
In accuracy.rst, correct rounding is required for add, sub, mul, and divide. I propose adding sqrt to this list.
Note that sqrt is not listed later among the mathematical functions whose accuracy is not precisely defined.
Note that the IEEE Std 754-2019 for Floating-Point Arithmetic mandates correct rounding for
squareRoot
.The text was updated successfully, but these errors were encountered: