From 536f8d97991d891fc7db333af1a5262497d85173 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Thu, 7 Apr 2022 06:34:43 -0700 Subject: [PATCH] Fix fail message construction in cc_shared_library Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ``` Closes #14697. PiperOrigin-RevId: 440090957 --- .../builtins_bzl/common/cc/experimental_cc_shared_library.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl b/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl index 62f6c799d394ae..62993092a43432 100644 --- a/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl +++ b/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl @@ -359,7 +359,7 @@ def _throw_error_if_unaccounted_libs(unaccounted_for_libs): libs_message.append(str(unaccounted_lib)) if len(unaccounted_for_libs) > 10: - libs_message = "(and " + str(len(unaccounted_for_libs) - 10) + " others)\n" + libs_message.append("(and " + str(len(unaccounted_for_libs) - 10) + " others)\n") static_deps_message = [] for repo in different_repos: