Fixed test failures #105
Merged
Fixed test failures #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 78.78% 78.90% +0.11%
==========================================
Files 14 14
Lines 1499 1498 -1
Branches 269 268 -1
==========================================
+ Hits 1181 1182 +1
+ Misses 230 229 -1
+ Partials 88 87 -1 ☔ View full report in Codecov by Sentry. |
nfx
added a commit
that referenced
this pull request
May 21, 2024
* Made `ProductInfo.version` a `cached_property` to avoid failure when comparing wheel uploads in development ([#105](#105)). In this release, the `apply` method of a class has been updated to sort upgrade scripts in semantic versioning order before applying them, addressing potential issues with version comparison during development. The implementation of `ProductInfo.version` has been refactored to a `cached_property` called `_version`, which calculates and caches the project version, addressing a failure during wheel upload comparisons in development. The `Wheels` class constructor has also been updated to include explicit keyword-only arguments, and a deprecation warning has been added. These changes aim to improve the reliability and predictability of the upgrade process and the library as a whole. Dependency updates: * Bump actions/checkout from 4.1.5 to 4.1.6 ([#106](#106)).
Merged
nfx
added a commit
that referenced
this pull request
May 21, 2024
* Made `ProductInfo.version` a `cached_property` to avoid failure when comparing wheel uploads in development ([#105](#105)). In this release, the `apply` method of a class has been updated to sort upgrade scripts in semantic versioning order before applying them, addressing potential issues with version comparison during development. The implementation of `ProductInfo.version` has been refactored to a `cached_property` called `_version`, which calculates and caches the project version, addressing a failure during wheel upload comparisons in development. The `Wheels` class constructor has also been updated to include explicit keyword-only arguments, and a deprecation warning has been added. These changes aim to improve the reliability and predictability of the upgrade process and the library as a whole. Dependency updates: * Bump actions/checkout from 4.1.5 to 4.1.6 ([#106](#106)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly is failing due to #103
ProductInfo.versionacached_property, to avoid failure when comparing wheel uploads in development