Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty group filter in install.py #216

Closed
larsgeorge-db opened this issue Sep 19, 2023 · 2 comments · Fixed by #217
Closed

Allow empty group filter in install.py #216

larsgeorge-db opened this issue Sep 19, 2023 · 2 comments · Fixed by #217
Assignees
@larsgeorge-db
Labels
enhancement New feature or request

Comments

@larsgeorge-db
Copy link
Contributor

The script right now wants users to enter a list of groups to migrate. Allow to not enter anything to trigger the automatic discovery of groups instead.
@larsgeorge-db larsgeorge-db added the enhancement New feature or request label Sep 19, 2023
@larsgeorge-db larsgeorge-db added this to the 1 month milestone Sep 19, 2023
@larsgeorge-db
Copy link
Contributor Author

@nfx you mentioned there is an issue with the auto discovery of groups? I thought I heard you saying that yesterday, please chime in here.

larsgeorge-db added a commit that referenced this issue Sep 19, 2023
@larsgeorge-db
Allow empty group filter in install.py (#216)
124656a 
Also fixes stripping whitespaces around groups when enters like `g1, g2, g3` etc. Previously the code expected to get no whitespaces.
@larsgeorge-db larsgeorge-db mentioned this issue Sep 19, 2023
Merged
@larsgeorge-db larsgeorge-db self-assigned this Sep 19, 2023
@nfx
Copy link
Collaborator

nfx commented Sep 19, 2023

@larsgeorge-db auto-discovery of groups doesn't work properly now

github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2023
@larsgeorge-db
Allow empty group filter in install.py (#216) (#217)
c079fb3 
Also fixes stripping whitespaces around groups when enters like `g1, g2,
g3` etc. Previously the code expected to get no whitespaces.

Fixes #216
@nfx nfx closed this as completed in #217 Sep 19, 2023
FastLee pushed a commit that referenced this issue Sep 19, 2023
@larsgeorge-db @FastLee
Allow empty group filter in install.py (#216) (#217)
77d58e4 
Also fixes stripping whitespaces around groups when enters like `g1, g2,
g3` etc. Previously the code expected to get no whitespaces.

Fixes #216
larsgeorge-db added a commit that referenced this issue Sep 21, 2023
@larsgeorge-db
Allow empty group filter in install.py (#216) (#217)
d342f8f 
Also fixes stripping whitespaces around groups when enters like `g1, g2,
g3` etc. Previously the code expected to get no whitespaces.

Fixes #216
@nfx nfx mentioned this issue Sep 21, 2023
Merged
nfx added a commit that referenced this issue Sep 21, 2023
@nfx
Release v0.1.1 (#261)
c3173eb 
* Added batched iteration for `INSERT INTO` queries in
`StatementExecutionBackend` with default `max_records_per_batch=1000`
([#237](#237)).
* Added crawler for mount points
([#209](#209)).
* Added crawlers for compatibility of jobs and clusters, along with
basic recommendations for external locations
([#244](#244)).
* Added safe return on grants
([#246](#246)).
* Added ability to specify empty group filter in the installer script
([#216](#216))
([#217](#217)).
* Added ability to install application by multiple different users on
the same workspace ([#235](#235)).
* Added dashboard creation on installation and a requirement for
`warehouse_id` in config, so that the assessment dashboards are
refreshed automatically after job runs
([#214](#214)).
* Added reliance on rate limiting from Databricks SDK for listing
workspace ([#258](#258)).
* Fixed errors in corner cases where Azure Service Principal Credentials
were not available in Spark context
([#254](#254)).
* Fixed `DESCRIBE TABLE` throwing errors when listing Legacy Table ACLs
([#238](#238)).
* Fixed `file already exists` error in the installer script
([#219](#219))
([#222](#222)).
* Fixed `guess_external_locations` failure with `AttributeError:
as_dict` and added an integration test
([#259](#259)).
* Fixed error handling edge cases in `crawl_tables` task
([#243](#243))
([#251](#251)).
* Fixed `crawl_permissions` task failure on folder names containing a
forward slash ([#234](#234)).
* Improved `README` notebook documentation
([#260](#260),
[#228](#228),
[#252](#252),
[#223](#223),
[#225](#225)).
* Removed redundant `.python-version` file
([#221](#221)).
* Removed discovery of account groups from `crawl_permissions` task
([#240](#240)).
* Updated databricks-sdk requirement from ~=0.8.0 to ~=0.9.0
([#245](#245)).
larsgeorge-db pushed a commit that referenced this issue Sep 23, 2023
@nfx @larsgeorge-db
Release v0.1.1 (#261)
340fab4 
* Added batched iteration for `INSERT INTO` queries in
`StatementExecutionBackend` with default `max_records_per_batch=1000`
([#237](#237)).
* Added crawler for mount points
([#209](#209)).
* Added crawlers for compatibility of jobs and clusters, along with
basic recommendations for external locations
([#244](#244)).
* Added safe return on grants
([#246](#246)).
* Added ability to specify empty group filter in the installer script
([#216](#216))
([#217](#217)).
* Added ability to install application by multiple different users on
the same workspace ([#235](#235)).
* Added dashboard creation on installation and a requirement for
`warehouse_id` in config, so that the assessment dashboards are
refreshed automatically after job runs
([#214](#214)).
* Added reliance on rate limiting from Databricks SDK for listing
workspace ([#258](#258)).
* Fixed errors in corner cases where Azure Service Principal Credentials
were not available in Spark context
([#254](#254)).
* Fixed `DESCRIBE TABLE` throwing errors when listing Legacy Table ACLs
([#238](#238)).
* Fixed `file already exists` error in the installer script
([#219](#219))
([#222](#222)).
* Fixed `guess_external_locations` failure with `AttributeError:
as_dict` and added an integration test
([#259](#259)).
* Fixed error handling edge cases in `crawl_tables` task
([#243](#243))
([#251](#251)).
* Fixed `crawl_permissions` task failure on folder names containing a
forward slash ([#234](#234)).
* Improved `README` notebook documentation
([#260](#260),
[#228](#228),
[#252](#252),
[#223](#223),
[#225](#225)).
* Removed redundant `.python-version` file
([#221](#221)).
* Removed discovery of account groups from `crawl_permissions` task
([#240](#240)).
* Updated databricks-sdk requirement from ~=0.8.0 to ~=0.9.0
([#245](#245)).
@nfx nfx removed this from the 1 month milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsgeorge-db larsgeorge-db

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow empty group filter in install.py (#216) databrickslabs/ucx
2 participants
@nfx @larsgeorge-db