Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MS Sqlserver #196

Closed
RobertLD opened this issue May 14, 2024 · 9 comments
Closed

Support for MS Sqlserver #196

RobertLD opened this issue May 14, 2024 · 9 comments

Comments

@RobertLD
Copy link
Contributor

Our company is actively pursuing stricter guarantees on cross-team data via the data contract-cli. We currently make use of MS SqlServer and would like to know if this is supported within the data contract cli?

@jochenchrist
Copy link
Contributor

Currently, it is not implemented, but should not be too difficult to implement, as soda-core supports ms sqlserver.

As a precondition, we'd need to add sqlserver to the server specification
https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#server-object

@jochenchrist
Copy link
Contributor

Would you (or your team) have some capacity to contribute a Pull-Request?

@RobertLD
Copy link
Contributor Author

I'm sure I can find some time to pull the code and investigate, hopefully sometime this week or next.

@jochenchrist
Copy link
Contributor

@RobertLD
Copy link
Contributor Author

RobertLD commented May 15, 2024

Added sqlserver to data contract specification: https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#sql-server-server-object

Including the supporting code, or just preparing the doc?

I've cloned the repo last night and was beginning to poke around

@simonharrer
Copy link
Contributor

Jochen added the server type to the specification.

What is now missing is adding support in the CLI within the python code base. Do you want to have a try for this @RobertLD ? It should be straight forward mapping to soda sqlserver type.

@RobertLD
Copy link
Contributor Author

I'll take a crack at it once I get my bearings

@RobertLD
Copy link
Contributor Author

Added sqlserver to data contract specification: https://github.com/datacontract/datacontract-specification/?tab=readme-ov-file#sql-server-server-object

Jochen added the server type to the specification.

What is now missing is adding support in the CLI within the python code base. Do you want to have a try for this @RobertLD ? It should be straight forward mapping to soda sqlserver type.

I've published a rough PR for the changes because the specification published earlier for SQLServer doesn't match exactly what I would expect (namely missing the driver, etc.)

With some guidance or an update of the spec I can continue work on it
#204

ty

@RobertLD
Copy link
Contributor Author

Completed in PR #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants