From e72df55d3857512eca4e3611c714a976839eefbd Mon Sep 17 00:00:00 2001 From: Ryan Scherle Date: Mon, 4 Nov 2024 21:36:14 +0000 Subject: [PATCH 1/2] Update rubocop config to ignore Ruby and gems --- .rubocop.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 88a59f2b11..3ff688a0a9 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -12,6 +12,7 @@ AllCops: - 'ui-library/**/*' - 'node_modules/**/*' - 'tmp/**/*' + - 'ruby/**/*' # Suppress complaints about post-2.0 syntax TargetRubyVersion: 3.0 @@ -126,6 +127,10 @@ Style/NumericPredicate: Style/SafeNavigation: Enabled: false +# SafeNavigation is always good, even in a long chain +Style/SafeNavigationChainLength: + Enabled: false + # Unclear why it's a good idea to give parameters semantically meaningless names Style/SingleLineBlockParams: Enabled: false From 0d4b21af72da988f96c23553e9f95aa663b435c4 Mon Sep 17 00:00:00 2001 From: Ryan Scherle Date: Mon, 4 Nov 2024 21:47:02 +0000 Subject: [PATCH 2/2] remove cop that doesn't work in GithubActions --- .rubocop.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 3ff688a0a9..142ac20738 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -127,10 +127,6 @@ Style/NumericPredicate: Style/SafeNavigation: Enabled: false -# SafeNavigation is always good, even in a long chain -Style/SafeNavigationChainLength: - Enabled: false - # Unclear why it's a good idea to give parameters semantically meaningless names Style/SingleLineBlockParams: Enabled: false