Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File previews for common file types #2993

Closed
sfisher opened this issue Dec 4, 2023 · 2 comments · Fixed by datadryad/dryad-app#1821
Closed

File previews for common file types #2993

sfisher opened this issue Dec 4, 2023 · 2 comments · Fixed by datadryad/dryad-app#1821

Comments

@sfisher
Copy link
Contributor

sfisher commented Dec 4, 2023

As part of the suggestions Karthik gave, he wanted to see file previews for common file types. Zenodo also does this for some items. We have (had) something for CSVs which I think maybe dropped out of our code at some point.

I didn't see this in the tickets, so I put this placeholder in case this is something people get to in the future.

Also may require some design thinking.

Related to https://github.com/orgs/CDL-Dryad/projects/1/views/15?pane=issue&itemId=22821524 and it seems like text file downloads are now saved rather than rendered and opened with the system viewer or other viewer which treats them better.

@ahamelers
Copy link
Collaborator

ahamelers commented Sep 4, 2024

It would be reasonable to allow previews for:

  • CSV, TSV
  • Plain text files, markdown
  • Most images
  • PDF
  • ZIP

I think zenodo also does most of these, with a max of 5MB for preview text and image total

@ahamelers ahamelers moved this from In progress to Review in Dryad product board Sep 4, 2024
@ahamelers
Copy link
Collaborator

I've implemented file previews for csv, tsv, plain text, and small web images.

PDF previews would require something like pdfJS, and zip content lists require us to look again at container_files and our compressed issues. I'll create a separate ticket for these.

@ryscher ryscher closed this as completed Sep 10, 2024
@github-project-automation github-project-automation bot moved this from Review to Completed in Dryad product board Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants