Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flagging of matched/unmatched funders on landing page #3055

Closed
bryanmgee opened this issue Jan 9, 2024 · 2 comments · Fixed by datadryad/dryad-app#1821
Closed

Comments

@bryanmgee
Copy link

While doing shadowing with Audrey and Dragos, I came across a dataset for which none of the funders were flagged with an asterisk on the landing page, but they were all listed as unmatched in editing mode (several had to have the name edited/translated in order to match). We thought that maybe the system was not flagging unmatched funders at all, but I have since found a few that are correctly flagging unmatched funders. In perhaps a related vein, I have also picked up datasets where upon initial curation, the system displays certain entered abbreviations (e.g., NSF for National Science Foundation) as a match in editing mode, but if you add a new entry and freeform enter 'NSF,' it does not match. I think that this may be related to something around Import Metadata since they often come with unmatched author affiliations and duplicated author entries as well.

@ahamelers ahamelers self-assigned this Jul 11, 2024
@ahamelers ahamelers moved this from Backlog to In progress in Dryad product board Jul 30, 2024
@ahamelers ahamelers moved this from In progress to Review in Dryad product board Aug 27, 2024
@ahamelers ahamelers removed their assignment Aug 28, 2024
@ahamelers ahamelers moved this from Review to In progress in Dryad product board Aug 28, 2024
@ahamelers ahamelers moved this from In progress to Backlog in Dryad product board Aug 28, 2024
@ahamelers
Copy link
Collaborator

ahamelers commented Aug 28, 2024

This is not an issue with the landing page or the front end; I believe it's with the API, and that funder names inserted that way are not getting the " *" added at the end as they do when added through the front end.

@ahamelers ahamelers self-assigned this Sep 3, 2024
@ahamelers ahamelers moved this from Backlog to In progress in Dryad product board Sep 3, 2024
@ahamelers
Copy link
Collaborator

Found that there was still some update code trying to exact match funder names not selected from the dropdown to the CrossRef funder list (which we no longer use, in favor of ROR) and not including the asterisk if a CrossRef match was found. So that could also be an origin of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants