Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Databricks: support column of type Text() as key #358

Closed
JCZuurmond opened this issue Dec 27, 2022 · 11 comments
Closed

Databricks: support column of type Text() as key #358

JCZuurmond opened this issue Dec 27, 2022 · 11 comments
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request non-dbt Use cases outside of dbt stale_immune Immunity to stale bot

Comments

@JCZuurmond
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We have tables that contain key columns with the type Text(). We can not change these columns; we have to use the tables as is.

Describe the solution you'd like

I want to use columns with the type Text() as the key.

Describe alternatives you've considered

None. If this feature will/can not be supported, then I will see if can create views that convert the key columns to numeric columns.

Additional context

Running on Databricks

@JCZuurmond JCZuurmond added the enhancement New feature or request label Dec 27, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label May 14, 2023
@JCZuurmond
Copy link
Contributor Author

👆

@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels May 15, 2023
@dlawin dlawin added help wanted Extra attention is needed --dbt Issues/features related to the dbt integration non-dbt Use cases outside of dbt and removed triage labels May 23, 2023
@dlawin
Copy link
Contributor

dlawin commented May 23, 2023

Is your feature request related to a problem? Please describe.

We have tables that contain key columns with the type Text(). We can not change these columns; we have to use the tables as is.

Describe the solution you'd like

I want to use columns with the type Text() as the key.

Describe alternatives you've considered

None. If this feature will/can not be supported, then I will see if can create views that convert the key columns to numeric columns.

Additional context

Running on Databricks

Thanks for reporting this @JCZuurmond, we're not currently working on this but may in the future, in the meantime we'd happily accept a community contribution

@leoebfolsom
Copy link
Contributor

A similar issue has cropped up related to Databricks Date PKs:

ERROR - Cannot use a column of type UnknownColType(text='DATE') as a key

@dlawin dlawin removed the help wanted Extra attention is needed label Jun 14, 2023
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Aug 14, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@JCZuurmond
Copy link
Contributor Author

👆

@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels Aug 21, 2023
@ism21
Copy link

ism21 commented Oct 19, 2023

Running into the same issue.

@dlawin dlawin reopened this Oct 19, 2023
@dlawin dlawin added stale_immune Immunity to stale bot and removed triage labels Oct 19, 2023
@ferdyh
Copy link

ferdyh commented Nov 1, 2023

Yes, same issue here... All columns we use have surrogate keys which are strings.

@dlawin
Copy link
Contributor

dlawin commented Nov 1, 2023

Context on why arbitrary strings are not supported (without some work) in #539

#539 (comment)

@glebmezh
Copy link
Contributor

Hi all -

I'm sorry for the delay in following up on this. @JCZuurmond, thank you for taking the time to raise this issue!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request non-dbt Use cases outside of dbt stale_immune Immunity to stale bot
Projects
None yet
Development

No branches or pull requests

6 participants