Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adapt to different countries support user change timezone #4651

Closed
wubx opened this issue Apr 1, 2022 · 3 comments · Fixed by #4878
Closed

Feature: Adapt to different countries support user change timezone #4651

wubx opened this issue Apr 1, 2022 · 3 comments · Fixed by #4878
Assignees
Labels
A-query Area: databend query C-feature Category: feature v0.8
Milestone

Comments

@wubx
Copy link
Member

wubx commented Apr 1, 2022

Summary

Support databend-query setting the global timezone, To adapt to different countries.

if the user not setting the timezone make it follow the os system.

@wubx wubx added the C-feature Category: feature label Apr 1, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Apr 1, 2022

This is a global session setting(work in progress, #3933).
Default should be UTC not the system timezone.
See https://docs.snowflake.com/en/sql-reference/parameters.html#timezone

@BohuTANG BohuTANG added the A-query Area: databend query label Apr 1, 2022
@wubx
Copy link
Member Author

wubx commented Apr 1, 2022

Learn from Snowflake that their timezone is just a session setting.

Type
Session — Can be set for Account » User » Session

Data Type
String (Constant)

Maybe session setting is enough.

@Veeupup
Copy link
Contributor

Veeupup commented Apr 13, 2022

This feature may have a lot of changes with functions and query files (hundreds of files), because we need to pass the parameter timezone from query to functions. And in the same time, we need to change the logical of date functions, so we need to change it into smaller tasks to make it.

@mergify mergify bot closed this as completed in #4878 May 7, 2022
@Xuanwo Xuanwo added this to the v0.8 milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-feature Category: feature v0.8
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants