-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data type): ArrayType support inner dataType #5049
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
41186a4
to
1eabcfa
Compare
|
||
select * from t12; | ||
|
||
select '==Array(String) Nullable=='; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't accept Array(String null)
, so tests should be covered about this type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CREATE TABLE IF NOT EXISTS t16(id Int, arr Array(String Null)) Engine = Memory; -- {ErrorCode 1005}
will parse error, we can't test this case in the stateless test.
@mergify update |
✅ Branch has been successfully updated |
c895c8f
to
fbe9978
Compare
Oops, CI failure:
https://github.com/datafuselabs/databend/runs/6333086848?check_suite_focus=true#step:3:437 |
Impressive Pr, this may be a conflict with #5167, cc @zhang2014 After merging it, |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
ArrayType support inner dataType
Changelog
Related Issues
Fixes #4974