-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): deprecate clickhouse's tcp protocol support #7012
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Is that ok if we remove these useless configs? Or just keep them as stale configs. I prefer to remove them.
|
We can remove them in the inner config, but still need to keep them in the outer config until we decide to do a break change to out config. |
I have two major passions in life.
|
My hobby is relatively simple: delete the code written by @sundy-li |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Now that the clickhouse tcp protocol has been removed, I think we no longer rely on clickhouse-driver.
I am also concerned if we need to keep the opensrv-clickhouse introduced in datavalues
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
deprecate clickhouse's tcp protocol support
See the RFC document for the reasons.
Fixes #6951