Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): deprecate clickhouse's tcp protocol support #7012

Merged
merged 9 commits into from
Aug 5, 2022

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Aug 5, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

deprecate clickhouse's tcp protocol support

See the RFC document for the reasons.

Fixes #6951

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Aug 5, 2022 at 10:30PM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 5, 2022
@sundy-li
Copy link
Member Author

sundy-li commented Aug 5, 2022

@Xuanwo @flaneur2020

Is that ok if we remove these useless configs? Or just keep them as stale configs.

I prefer to remove them.

# Query ClickHouse Handler.
pub clickhouse_handler_host: String,
pub clickhouse_handler_port: u16,

@Xuanwo
Copy link
Member

Xuanwo commented Aug 5, 2022

We can remove them in the inner config, but still need to keep them in the outer config until we decide to do a break change to out config.

@sundy-li sundy-li marked this pull request as ready for review August 5, 2022 15:12
@sundy-li
Copy link
Member Author

sundy-li commented Aug 5, 2022

I have two major passions in life.

  1. Writing code
  2. Delete the code I have written

@Xuanwo
Copy link
Member

Xuanwo commented Aug 5, 2022

I have two major passions in life.

  1. Writing code
  2. Delete the code I have written

My hobby is relatively simple: delete the code written by @sundy-li

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Now that the clickhouse tcp protocol has been removed, I think we no longer rely on clickhouse-driver.

I am also concerned if we need to keep the opensrv-clickhouse introduced in datavalues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: with clickhouse tcp mode, insert a timestamp type value with ns the ck client will hang
4 participants