Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing logo on Snowflake datasets with DataHub 0.8 #2795

Closed
remisalmon opened this issue Jun 29, 2021 · 3 comments
Closed

Missing logo on Snowflake datasets with DataHub 0.8 #2795

remisalmon opened this issue Jun 29, 2021 · 3 comments
Labels
bug Bug report

Comments

@remisalmon
Copy link
Contributor

Describe the bug

With DataHub v0.8.4 and v0.8.3, Snowflake datasets are missing the Sowflake logo from the UI:
image

To Reproduce

Steps to reproduce the behavior:

  1. Nuke & quickstart DataHub v0.8.4
  2. Ingest Snowflake metadata
  3. Browse Snowflake datasets from the UI

Reproduced on MacOS and Linux & with Firefox and Chrome.

Expected behavior

What it looks like in DataHub v0.7:
image

@remisalmon
Copy link
Contributor Author

Same issue with lookml datasets in Datasets/prod/looker.

Looker dashboard in Dashboards/looker are showing the right logo as expected.

@jameslamb
Copy link
Contributor

I just upgraded to 0.8.8 and can see the datasets with the following are missing logos in the lineage view in the UI.

  • dataPlatform:hive
  • dataPlatform:looker
  • dataPlatform:postgres
  • dataPlatform:redshift

Those are all platforms with logoUrl defined in https://github.com/linkedin/datahub/blob/7083de9b4f9740b1c47535c909619fe40487471f/gms/impl/src/main/resources/DataPlatformInfo.json, so I'm not sure why they aren't showing up.

Logos are showing up correctly for Airflow pipelines / tasks and Looker dashboards / charts .

If maintainers could point me in the general direction of where "look up the logo from the dataPlatform" code lives, I'd be happy to try fixing this.

#2783 fixed one such issue (#2738, about mongoDB logos) but I can't tell from that diff how this mechanism works.

@remisalmon
Copy link
Contributor Author

Fixed with DataHub v0.8.13: https://github.com/linkedin/datahub/releases/tag/v0.8.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants