Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: refactor the XlineServer #293

Closed
Phoenix500526 opened this issue May 25, 2023 · 0 comments · Fixed by #294
Closed

Refactor: refactor the XlineServer #293

Phoenix500526 opened this issue May 25, 2023 · 0 comments · Fixed by #294
Assignees
@Phoenix500526
Labels
enhancement New feature or request
Milestone
v0.4.1

Comments

@Phoenix500526
Copy link
Collaborator

Currently, we have split the construction logic of XlineServer into two parts. One is placed in the new method, which is responsible for creating various underlying data structures. The other part is placed in the init_server method, which is responsible for assembling the corresponding servers. This approach can make XlineServer become a giant structure because any intermediate structure needed to be stored in XlineServer, which increases the reading burden.
@Phoenix500526 Phoenix500526 self-assigned this May 25, 2023
@Phoenix500526 Phoenix500526 added the enhancement New feature or request label May 25, 2023
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 26, 2023
@Phoenix500526
refactor: refactor XlineServer
68361b0 
Read issue xline-kv#293 for more details

Closes xline-kv#293
@Phoenix500526 Phoenix500526 mentioned this issue May 26, 2023
Merged
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 26, 2023
@Phoenix500526
refactor: refactor XlineServer
76351fc 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 26, 2023
@Phoenix500526
refactor: refactor XlineServer
2076693 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 26, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
3741a07 
Closes xline-kv#293
@Phoenix500526 Phoenix500526 linked a pull request May 27, 2023 that will close this issue
Refactor/XlineServer #294
Merged
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 27, 2023
@Phoenix500526
refactor: refactor XlineServer
c7d0089 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 27, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
9b1b9ef 
Closes xline-kv#293
@Phoenix500526 Phoenix500526 added this to the Release v0.4.1 milestone May 27, 2023
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 29, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
5654da3 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 29, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
2d63879 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 30, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
c7a581d 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 31, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
75e4c98 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 31, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
20458dd 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 31, 2023
@Phoenix500526
refactor: refactor XlineServer
4b4117b 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue May 31, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
8eab186 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 1, 2023
@Phoenix500526
refactor: refactor XlineServer
7a2c72c 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 1, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
58d0ada 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
019e67a 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
7ed11ef 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: refactor XlineServer
205f813 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
99d538e 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: refactor XlineServer
68b3b80 
Read issue xline-kv#293 for more details

Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
ade4832 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
358cc84 
Closes xline-kv#293
Phoenix500526 added a commit to Phoenix500526/Xline that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
163fd36 
Closes xline-kv#293
Phoenix500526 added a commit that referenced this issue Jun 2, 2023
@Phoenix500526
refactor: add a ClusterMember structure to wrap all_members info
23a84d2 
Closes #293
bsbds pushed a commit to bsbds/Xline that referenced this issue Jun 5, 2023
@Phoenix500526 @bsbds
refactor: refactor XlineServer
6a093c8 
Read issue xline-kv#293 for more details

Closes xline-kv#293
bsbds pushed a commit to bsbds/Xline that referenced this issue Jun 5, 2023
@Phoenix500526 @bsbds
refactor: add a ClusterMember structure to wrap all_members info
912ca5e 
Closes xline-kv#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phoenix500526 Phoenix500526

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging a pull request may close this issue.

Refactor/XlineServer Phoenix500526/Xline
1 participant
@Phoenix500526