From 393b307991b4cb8227cd59e5063b279277f953fa Mon Sep 17 00:00:00 2001
From: "Akihiko (Aki) Kuroda" <16141898+akihikokuroda@users.noreply.github.com>
Date: Mon, 12 Feb 2024 09:42:15 -0500
Subject: [PATCH] Take out unnecessary Job.save() (#1217)

* take out unnecessary Job.save()

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
---
 gateway/api/services.py | 28 ++++++++--------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/gateway/api/services.py b/gateway/api/services.py
index 9c9741983..ced57d50b 100644
--- a/gateway/api/services.py
+++ b/gateway/api/services.py
@@ -168,25 +168,13 @@ def save(
             Job instance
         """
 
-        job = None
-        try:
-            job = Job(
-                program=program,
-                arguments=arguments,
-                author=author,
-                status=status,
-                config=jobconfig,
-            )
-            job.save()
-        except (Exception) as save_job_exception:
-            logger.error(
-                "Exception was caught saving a Job. \n Error trace: %s",
-                save_job_exception,
-            )
-            raise InternalServerErrorException(
-                "Unexpected error saving a job"
-            ) from save_job_exception
-
+        job = Job(
+            program=program,
+            arguments=arguments,
+            author=author,
+            status=status,
+            config=jobconfig,
+        )
         env = encrypt_env_vars(build_env_variables(token, job, json.dumps(arguments)))
         try:
             env["traceparent"] = carrier["traceparent"]
@@ -198,7 +186,7 @@ def save(
             job.save()
         except (Exception) as save_job_exception:
             logger.error(
-                "Exception was caught saving the env_vars of the Job[%s]. \n Error trace: %s",
+                "Exception was caught saving the Job[%s]. \n Error trace: %s",
                 job.id,
                 save_job_exception,
             )