Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show divider after last item #456

Closed
vaggelis-net opened this issue Sep 27, 2017 · 7 comments
Closed

Show divider after last item #456

vaggelis-net opened this issue Sep 27, 2017 · 7 comments
Milestone

Comments

@vaggelis-net
Copy link

Hello,
Is there a way to show a divider after the last item?
I'm using the default divider with withDefaultDivider() but it's not displayed beneath the last item.

Thank you.

@davideas
Copy link
Owner

Hello @de-Stan, the last line is removed on purpose:

for (int i = 0; i < itemCount - 1; i++) {
   ...
}

@vaggelis-net
Copy link
Author

I see got it.
Just an idea should there be an option like withDividerAfterLastItem() or something similar to provide such functionality?

@davideas
Copy link
Owner

davideas commented Sep 28, 2017

@de-Stan, last item is always at the bottom/right edge of the screen, that line shouldn't be visible, normally, as it isn't visible on the first item. Do you want it visible?

@vaggelis-net
Copy link
Author

In our current project the client asked for it. There is a recyclerview that might contain just a couple of items so it would be better (visual only) if the divider was there.
It's easy for me to clone and edit or just create the item layout to contain the divider and drop the ItemDecoration altogether.
Also an idea if you want to include it in your library for such cases.

@davideas
Copy link
Owner

davideas commented Sep 28, 2017

Well, in that case, we can always add it as feature.

@davideas davideas reopened this Sep 28, 2017
@davideas davideas added this to the 5.0.0-rc3 milestone Sep 28, 2017
@vaggelis-net
Copy link
Author

vaggelis-net commented Sep 28, 2017 via email

@davideas
Copy link
Owner

@de-Stan, sorry I was already there to fix a small bug in another class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants